Addon upgrade flux 2.4 #766
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugbuilder
requested review from
wangyikewxgm,
FogDong,
charlie0129,
anoop2811 and
dhiguero
as code owners
wonderflow
previously approved these changes
Nov 29, 2024
Signed-off-by: bugbuilder <[email protected]>
Signed-off-by: bugbuilder <[email protected]>
Signed-off-by: bugbuilder <[email protected]>
Signed-off-by: bugbuilder <[email protected]>
wonderflow
previously approved these changes
Dec 4, 2024
|
oops, sorry the conflict happen when I merged other PR |
Signed-off-by: bugbuilder <[email protected]>
No worries, already fixed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update includes all the necessary changes to upgrade Flux to its 2.4 GA version, ensuring compatibility and enhanced functionality for the addon. The key changes are:
Some practices, such as priorityClassName, securityContext, and terminationGracePeriodSeconds, were not implemented as they are currently not supported by the webservice component type. Discussions regarding their support are still ongoing in the community, as referenced in kubevela/kubevela#5580.
I would appreciate clarification on what types of tests should be run to ensure the changes meet the project's merge requirements. This would help validate the implementation further and ensure compatibility across different environments.